Add chenrui333 to reviewer list #4825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/invalid-commit-message
|
/lgtm Welcome to dashboard/i18n/ |
k8s-ci-robot
added
the
lgtm
|
/approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chenrui333, hwdef, maciaszczykm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chenrui333
changed the title
Codecov Report
@@ Coverage Diff @@
## master #4825 +/- ##
==========================================
- Coverage 45.43% 45.42% -0.02%
==========================================
Files 214 214
Lines 9977 9977
Branches 94 94
==========================================
- Hits 4533 4532 -1
- Misses 5180 5181 +1
Partials 264 264
Continue to review full report at Codecov.
|
|
Welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my pitch, I am the sig-docs-zh-owner, and I did contribute/help manage bunch of PRs in the past (full list, https://github.com/kubernetes/website/pulls?q=is%3Apr+author%3Achenrui333+is%3Aclosed), I am trying to help with dashboard translation work in here too.
Hence, adding myself to the reviewer list.
/cc @hwdef